Project Management

Please login or join to subscribe to this thread

Code Review. Why and when should it be done?

linkedin twitter facebook   Agile   Information Technology   Schedule Management   Scheduling  
avatar
Joseph Pangan Senior Principal Consultant| Genpact Philippines Angeles City, Philippines, Philippines
I almost always find development teams perform code reviews.
Time is almost always allotted to do this task but unless there are issues, the decision is almost always "to do more tests, release and publish".
I understand that companies and development teams have coding standards etc.to comply with and the logic has to be checked to minimise potential bugs etc., but should this always be done?
Is the step, potentially, a waste?
Why and when should it be done to ensure waste in the process is minimized?
Sort By:
< 1 2 >
avatar
Joseph Pangan Senior Principal Consultant| Genpact Philippines Angeles City, Philippines, Philippines
Apr 16, 2019 3:22 PM
Replying to Wade Harshman
...
Joseph,
Extreme Programming (XP) takes code reviews one step further, by teaming developers together in a practice called "pair programming."

A common managerial criticism of this practice is that it reduces productivity. But this criticism is based on a flawed assumption that writing software is nothing more than pounding keyboards. If this were true, we'd hire developers based on typing speed. In reality, though, development teams are not held back by typing speed, but by the flow of ideas. Pair programming accelerates software development by allowing programmers to solve problems together.

Although this is a defining practice of XP, there's a fundamental XP principle which states we must be willing to let go of practices that are no longer useful. From that aspect, if you find that code reviews are a waste, then you should be willing to change the way you're operating. I would suggest, however, that before your team simply abandons code review, you first ask why code reviews are not effective.
- Extreme Programming (XP) takes code reviews one step further, by teaming developers together in a practice called "pair programming."

Thanks Wade!
avatar
Joseph Pangan Senior Principal Consultant| Genpact Philippines Angeles City, Philippines, Philippines
Apr 16, 2019 9:42 AM
Replying to Sergio Luis Conte
...
This is a matter of quality assurance. Is not a wasted at all, mainly if you are working into Agile based environments.This is not a new practice. This is an old practice. The problem is into the attitude of people that are in charge to conduct the review. Is like when you face an audit process. Most of the auditors think that they must behave as police woman/officer.
-Quality assurance.

Thanks Sergio.
avatar
Joseph Pangan Senior Principal Consultant| Genpact Philippines Angeles City, Philippines, Philippines
Apr 16, 2019 8:40 AM
Replying to Ashok Kumar
...
Peer review should be essential to ensure good and consistent quality of the deliverables. It enables adherence to established standard practices, proofreading of contents and most importantly, the verification of approach pursued in the deliverable.
Thanks Ashok for the feedback.
avatar
Joseph Pangan Senior Principal Consultant| Genpact Philippines Angeles City, Philippines, Philippines
Apr 16, 2019 7:47 AM
Replying to Abolfazl Yousefi Darestani
...
Well, answering this question is a little bit tricky. this task may or may not be a waste. It has to do with your strategy, plan, etc.
Thanks Abolfazl.
< 1 2 >

Please login or join to reply

Content ID:
ADVERTISEMENTS

"The degree of one's emotion varies inversely with one's knowledge of the facts--the less you know, the hotter you get."

- Bertrand Russell

ADVERTISEMENT

Sponsors